[DRAFT] [Help wanted] Sign zoom handles #1479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Y axis placement is still too High.
Y: If scale > 1, placement is perfect, if scale == 1 placement is a bit too low on the doc
…ure. X is working with scale = 1 now, increasing zoom and the placement is getting more and more off
…y coordinate calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign Zoom Handles
Opening this Draft PR regarding the issue #1247 . I implemented a basic zoom functionality but have not been able to get the calculation of the position 100% correct when the signature is placed while zooming. (Placement is correct when no zoom is used)
Here is an example of what i mean:
As you can see the signature is alittle bit to high and a little bit too far left. This error is getting worse with increasing zoom. At this point i do not have an explanation for it anymore. So if anyone would like to pick this up and work on it, please do!
This is how i am calculating the position: (example for x coordinate)
The Blue Part is the actual Document. The white part is the part of the document that is visible in the viewport when you are zooming.
I would be happy about some help or as I already said if some one wants to work on this it would be fine for me as well.
Checklist:
Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)